Skip to content

Added proxy check for endpoint and removed duplicate code#1455

Merged
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:proxy-fix
Oct 7, 2024
Merged

Added proxy check for endpoint and removed duplicate code#1455
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:proxy-fix

Conversation

@aayushchouhan09
Copy link
Member

@aayushchouhan09 aayushchouhan09 commented Oct 3, 2024

Explain the changes

  1. We have added a proxy status check for the endpoint and removed the duplicate code.

Screenshot from 2024-10-07 14-52-39

Issues: Fixed #xxx / Gap #xxx

  1. Enhancement: Added a CLI sub-command in noobaa diagnostics to print proxy details #1440
  2. Enhancement: Printing overrided vars in cli command noobaa diagnostics report #1445

Testing Instructions:

  1. After installing noobaa run the cli command noobaa diagnostics report to see the output.

@aayushchouhan09 aayushchouhan09 requested review from a team, Neon-White, liranmauda, nbecker-cibot and shirady and removed request for a team October 3, 2024 11:15
@aayushchouhan09 aayushchouhan09 requested review from aspandey and removed request for nbecker-cibot October 3, 2024 11:16
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liranmauda
Copy link
Contributor

Do not forget to squash the commits.

Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@aayushchouhan09 aayushchouhan09 merged commit 0ae4f76 into noobaa:master Oct 7, 2024
@aayushchouhan09 aayushchouhan09 deleted the proxy-fix branch May 6, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants