Skip to content

NOOBAA_LOG_COLOR - Add check env var is not null#1446

Merged
jackyalbo merged 1 commit intonoobaa:masterfrom
jackyalbo:jacky-fix-new
Sep 25, 2024
Merged

NOOBAA_LOG_COLOR - Add check env var is not null#1446
jackyalbo merged 1 commit intonoobaa:masterfrom
jackyalbo:jacky-fix-new

Conversation

@jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Sep 25, 2024

Explain the changes

  1. When we upgrade between versions with NOOBAA_LOG_COLOR from one with none. it's possible that the pod won't have this env var and will return null, in this case we will get segmentation fault
  2. fixed to check if null; if so, don't check the value.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo
Add check env var is not null
1bf5238 
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@jackyalbo jackyalbo changed the title Add check env var is not null NOOBAA_LOG_COLOR - Add check env var is not null Sep 25, 2024
@jackyalbo jackyalbo merged commit c78337f into noobaa:master Sep 25, 2024
@jackyalbo jackyalbo deleted the jacky-fix-new branch June 11, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@liranmauda liranmauda liranmauda approved these changes

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackyalbo @nimrod-becker @liranmauda