Skip to content

Updated forceMD5Etag to boolean pointer type#1430

Merged
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:force_md5_etag
Sep 26, 2024
Merged

Updated forceMD5Etag to boolean pointer type#1430
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09:force_md5_etag

Conversation

@aayushchouhan09
Copy link
Member

@aayushchouhan09 aayushchouhan09 commented Sep 9, 2024 •
edited
Loading

Explain the changes

  1. Updated forceMd5Etag to a Boolean Pointer Type (*bool): The forceMd5Etag flag is now handled as a pointer to a boolean (*bool) to explicitly track whether the flag was provided by the user:
  • If the flag was set, forceMd5Etag points to a true or false value.
  • If the flag was not set, forceMd5Etag remains nil, preventing unintended changes to the ForceMd5Etag field.

Issues: Fixed #xxx / Gap #xxx

  1. Improvement: Added support for force_md5_etag for bucket and account #1215
  2. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2312533

Testing Instructions:

  1. Try creating and updating the bucket using cli.
  2. Try creating and updating the NoobaaAccount using cli and yaml both.

@aayushchouhan09 aayushchouhan09 force-pushed the force_md5_etag branch 2 times, most recently from d7745a2 to 0ff1930 Compare September 10, 2024 14:54
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 10, 2024
@aayushchouhan09 aayushchouhan09 requested review from a team and tangledbytes and removed request for a team September 12, 2024 06:42
@jackyalbo
Copy link
Contributor

jackyalbo commented Sep 12, 2024

@achouhan09 I remember @dannyzaken had issues when changing API schemas between versions. Did you test upgrade where there was a noobaaAccount with true/false set and if it worked after moving to the new schema in the later version?
Try doing a whole upgrade procedure of running with the old CRD and then changing to the new one and see if everything still works(can maybe check with the cli upgrade command - if it supports upgrading the CRDs)

dannyzaken
dannyzaken reviewed Sep 18, 2024
View reviewed changes
dannyzaken
dannyzaken requested changes Sep 19, 2024
View reviewed changes
@aayushchouhan09 aayushchouhan09 force-pushed the force_md5_etag branch 2 times, most recently from a31ae00 to a80d341 Compare September 20, 2024 12:40
aayushchouhan09
aayushchouhan09 commented Sep 20, 2024
View reviewed changes
dannyzaken
dannyzaken reviewed Sep 25, 2024
View reviewed changes
@aayushchouhan09
Updated forceMD5Etag to boolean pointer type to work efficiently
a914ff5 
Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
@aayushchouhan09 aayushchouhan09 merged commit c95af10 into noobaa:master Sep 26, 2024
@aayushchouhan09 aayushchouhan09 deleted the force_md5_etag branch September 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

@liranmauda liranmauda Awaiting requested review from liranmauda

@tangledbytes tangledbytes Awaiting requested review from tangledbytes tangledbytes was automatically assigned from noobaa/dev

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aayushchouhan09 @jackyalbo @dannyzaken