Added a validation check for quota config in bucket#1418
Merged
aayushchouhan09 merged 1 commit intonoobaa:masterfrom Sep 26, 2024
Merged
Added a validation check for quota config in bucket#1418aayushchouhan09 merged 1 commit intonoobaa:masterfrom
aayushchouhan09 merged 1 commit intonoobaa:masterfrom
Conversation
8b4d503 to
7a19d30
Compare
aayushchouhan09
commented
Aug 22, 2024
pkg/bucket/bucket.go
Outdated
| if updateQuota { | ||
| err = nbClient.CreateBucketAPI(nb.CreateBucketParams{Name: bucketName, Tiering: tierName, ForceMd5Etag: forceMd5Etag}) | ||
| if err == nil && updateQuota { | ||
| err = nbClient.UpdateBucketAPI(nb.CreateBucketParams{Name: bucketName, Quota: "a}) |
Member
Author
There was a problem hiding this comment.
Not sure why we havn't added quota in create_bucket api, so we need to call update_bucket api with quota again here.
@vh05 @liranmauda Anything you want to add?
Contributor
There was a problem hiding this comment.
I think we have not introduce there because we fully not supporting quota. @liranmauda @dannyzaken Please correct me if wrong
7a19d30 to
525c1a8
Compare
vh05
reviewed
Sep 3, 2024
pkg/bucket/bucket.go
Outdated
| if updateQuota { | ||
| err = nbClient.CreateBucketAPI(nb.CreateBucketParams{Name: bucketName, Tiering: tierName, ForceMd5Etag: forceMd5Etag}) | ||
| if err == nil && updateQuota { | ||
| err = nbClient.UpdateBucketAPI(nb.CreateBucketParams{Name: bucketName, Quota: "a}) |
Contributor
There was a problem hiding this comment.
I think we have not introduce there because we fully not supporting quota. @liranmauda @dannyzaken Please correct me if wrong
525c1a8 to
ebf9046
Compare
vh05
reviewed
Sep 3, 2024
vec-tr
suggested changes
Sep 26, 2024
Contributor
vec-tr
left a comment
There was a problem hiding this comment.
Please squal and push the changes.
vh05
suggested changes
Sep 26, 2024
Contributor
vh05
left a comment
There was a problem hiding this comment.
Please squash and push the changes
Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
e7279cc to
0a88243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: