noobaa/operator: Provide option to disable log colors#1410
Merged
aspandey merged 1 commit intonoobaa:masterfrom Aug 22, 2024
Merged
noobaa/operator: Provide option to disable log colors#1410aspandey merged 1 commit intonoobaa:masterfrom
aspandey merged 1 commit intonoobaa:masterfrom
Conversation
5c2cb41 to
f6768dc
Compare
liranmauda
requested changes
Aug 13, 2024
f6768dc to
3916fa2
Compare
liranmauda
approved these changes
Aug 15, 2024
Contributor
liranmauda
left a comment
There was a problem hiding this comment.
LGTM, Let's wait for the core PR before merging this one.
443d404 to
6f4f743
Compare
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
6f4f743 to
a44776d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
This patch is in sync with the changes on noobaa-core side.
noobaa/noobaa-core#8281
We need to make sure a user can enable/disable the log color generated by core, endpoint and backing store.
Fixes: