Add NOOBAA_LOG_LEVEL to the agent pod#1407
Merged
liranmauda merged 1 commit intonoobaa:masterfrom Aug 11, 2024
Merged
Conversation
cd27ac2 to
8772449
Compare
jackyalbo
reviewed
Aug 11, 2024
jackyalbo
reviewed
Aug 11, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| err = c.Watch(source.Kind(mgr.GetCache(), &corev1.ConfigMap{}), ownerHandler, &filterForNoobaaOwnerPredicate, &logEventsPredicate) |
Contributor
There was a problem hiding this comment.
wouldn't this will run all backingstores in case of change in the config map? can we run somehow only the pvpool type?
Contributor
Author
There was a problem hiding this comment.
This will only happen when the configmap noobaa-config will change, which is not a lot.
in that case the reconcile will trigger, but the actual change is only on the reconcile of the PV pool.
- Add NOOBAA_LOG_LEVEL to the agent pod - Watching for changes in the noobaa-config on the backingstore reconciler - Updating the NOOBAA_LOG_LEVEL according to the config map Signed-off-by: liranmauda <liran.mauda@gmail.com>
8772449 to
ec773dc
Compare
jackyalbo
approved these changes
Aug 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Fixes: