Added TopologySpreadConstraints to the backingstore pod for better performance#1401
Merged
aayushchouhan09 merged 2 commits intonoobaa:masterfrom Aug 5, 2024
Merged
Conversation
3a25a0a to
b8df38f
Compare
…rformance Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
b8df38f to
ef5de51
Compare
naveenpaul1
reviewed
Aug 1, 2024
pkg/backingstore/reconciler.go
Outdated
| "pool": r.BackingStore.Name, | ||
| "app": "noobaa", | ||
| "pool": r.BackingStore.Name, | ||
| "noobaa-backingstore": r.Request.Name, |
Contributor
There was a problem hiding this comment.
why noobaa-backingstore added?
Member
Author
There was a problem hiding this comment.
We need to add a label to all the backingstore pods so that topology constraints should work. The current two labels would not work in here so I need to add one. Please correct me if I am wrong. Thanks
pkg/backingstore/reconciler.go
Outdated
| // Add topology spread constraints | ||
| honor := corev1.NodeInclusionPolicyHonor | ||
| if r.PodAgentTemplate.Spec.TopologySpreadConstraints != nil { | ||
| r.Logger.Info("TopologySpreadConstraints already exists...") |
Contributor
There was a problem hiding this comment.
mention it is backing store in log, to make debugging easier.
Member
Author
There was a problem hiding this comment.
Sure, I will try to do something better. Thanks
Member
Author
There was a problem hiding this comment.
We cannot print the backingstore name here, as in this step we are updating the pod template itself for backingstore pod
… more log info Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
7ff9505 to
a11a7e6
Compare
liranmauda
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: