disable automatic mount of SA token for pv-pool pod#1399
Merged
dannyzaken merged 1 commit intonoobaa:masterfrom Aug 7, 2024
Merged
disable automatic mount of SA token for pv-pool pod#1399dannyzaken merged 1 commit intonoobaa:masterfrom
dannyzaken merged 1 commit intonoobaa:masterfrom
Conversation
Member
|
This reminds me that we have |
tangledbytes
approved these changes
Jul 30, 2024
nimrod-becker
approved these changes
Aug 1, 2024
Member
Author
I think it was used for SSO into noobaa UI, so it's not relevant anymore |
Kubernetes automatically mounts a service account token for every pod by default. The best practice is to mount it only for pods that require access to the Kubernetes API. For now, disabling automount for pv-pool pods. We should consider it for all pods other than the operator. Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: