CI | Admission Tests Changes - Integration and Workflow#1046
Merged
shirady merged 1 commit intonoobaa:masterfrom Feb 22, 2023
Merged
CI | Admission Tests Changes - Integration and Workflow#1046shirady merged 1 commit intonoobaa:masterfrom
shirady merged 1 commit intonoobaa:masterfrom
Conversation
2 tasks
c0f617b to
edd0005
Compare
42f42dc to
02dd034
Compare
Contributor
Author
|
Moved to draft because I had an issue with the indentation in the YAML file. |
02dd034 to
b033f82
Compare
dannyzaken
reviewed
Feb 19, 2023
dannyzaken
approved these changes
Feb 19, 2023
Member
dannyzaken
left a comment
There was a problem hiding this comment.
one small comment. otherwise looks good
liranmauda
approved these changes
Feb 20, 2023
Changes in the admission tests (integration tests): Separate the last delete test (It, Should Allow) into 2 tests (backingstore and namespacestore). Set the default resource explicitly before starting the first delete operation test. Changes in the admission test workflow: Clone core repo and build it. Install nb with max resources to pass the tests. Collect logs and upload artifacts. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
b033f82 to
8c91d93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Changes in the admission tests (integration tests):
Changes in the admission test workflow:
Issues:
Testing Instructions: