fix: remove redundant aria-disabled=false from swiper nav button#8176
Merged
nolimits4web merged 2 commits intonolimits4web:masterfrom Apr 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7975
Problem
Two invalid ARIA attributes on the swiper nav buttons were flagged by accessibility checkers (e.g. Eye-Able, axe-core):
aria-disabled="false"is an invalid ARIA value. When a button is not disabled, the correct approach is to omit the attribute entirely.aria-controlsreferences an ID that is only set inside the Shadow DOM. ARIA ID references do not work across Shadow DOM boundaries and are therefore invisible to assistive technologies — making the attribute misleading and ineffective.Changes
aria-disabled="false"from next/prev buttons — the buttons remain fully functional and accessible without it.aria-controlsfrom next/prev buttons —aria-labelalready communicates the button's purpose clearly.