fix(core): avoid double-subtracting offsets in centerInsufficientSlides#8158
Merged
nolimits4web merged 1 commit intonolimits4web:masterfrom Feb 13, 2026
Merged
Conversation
Owner
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
centerInsufficientSlideswithslidesOffsetBefore/Afterin v12Summary
In Swiper v12.0.0+,
centerInsufficientSlidesunder-centers slides whenslidesOffsetBeforeand/orslidesOffsetAfterare set. The wrapper ends up shifted by(offsetBefore + offsetAfter) / 2compared to v11 behavior. This PR fixes the centering math so offsets are applied exactly once.Root cause
Starting in v12 (commit
74cc297),updateSlides()computes:swiperSize = swiper.size - offsetBefore - offsetAfterBut the
centerInsufficientSlidesblock still treated offsets as not accounted for and subtracted them again viaoffsetSize, effectively shrinking the available size by2 * (offsetBefore + offsetAfter).Reproduction
Minimal config:
Verification
0/ unset.