fix(a11y): improved aria-label for status and notifications#690
Merged
Conversation
Owner
Author
|
OK, we are now only formatting dates once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #689
I made a slight modification to the Mastodon frontend's system by adding "Public"/"Unlisted"/"Followers-only"/"Direct" to the end of the
aria-label, since this seems like useful information and is only subtly indicated elsewhere. (E.g. in the fact that you can't boost a direct/followers-only status.)This adds a bit of a perf hit because we now need to use
DOMParserto parse HTML to strings, but I measured it, and it seems to be measurable but not huge (on the order of 0.5ms -> 1.5ms per toot on my desktop when running in Chrome at 4x slowdown). We also take a slight perf hit because we are now parsing dates twice, but this is also fairly negligible (0-1ms per date formatted). I'm not super concerned since #656 has moved scrolling off-main-thread for all browsers.We still don't have
j/kkeyboard scrolling, so I admit I'm not sure how useful this is to screen reader users. I also don't have a good screen reader to test on right now, since my Mac is busted. But hopefully this helps.