Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@illegalcall do you mind running cargo t --release and accepting snapshot changes via cargo insta accept and committing that? I can't push to this branch otherwise I'd run them myself. This should fix the failing Test / Run tests (partition N) CI instances.

Hey @jfecher, absolutely my pleasure to run the scripts. I have accepted the changes.

@illegalcall sorry, one more command to run for stdlib changes: just stdlib_docs or if you don't have or want to install just, then:

$ cd noir_stdlib && nargo doc
$ rm -rf noir_stdlib/docs
$ mv noir_stdlib/target/docs noir_stdlib/docs

(I'd also appreciate if you could add subarray to cspell.json)

Yeah, ofcourse. Doing this right now.

Done. Lets hope CI passes this time 🤞

@illegalcall looks like there's still a diff when running just stdlib_docs again. Can you run it again?

@jfecher Um, I am not sure what am I missing.

I have redone the cargo t --release build,
run just stdlib_docs : creates docs, no diff
run cd noir_stdlib && nargo doc : creates docs, no diff.

run

$ rm -rf noir_stdlib/docs
$ mv noir_stdlib/target/docs noir_stdlib/docs

still no diff.

Should i rollback 1 commit and regen and force push?
Do you have any other ideas i can try to actually be sure about the issue.

To be extra sure, i have cloned the repo again and ran the same commands, only to reach the same outcome. :(

(I am eager to know about the issue, and would love to work with you and fix this. illegalcall is my discord username too, and i am on Noir server)

@illegalcall odd, when I pulled this PR and ran just stdlib_docs locally I saw a diff. You can try installing just and running the command that way but it should just be a shortcut for the commands I gave.

@jfecher Yeah, when i run i dont see a diff.

And following the docs rm and mv commands results in the same doc.
@jfecher If youre able to see the diff, can you paste the diff here and i apply the diff?

@illegalcall it calls nargo doc directly so maybe you need a cargo b beforehand or ensure the nargo it is referring to is your local one and not a global one you have installed elsewhere. After that, do you see any uncommitted changes?

The diff is here https://github.com/noir-lang/noir/actions/runs/21960924441/job/63438631636?pr=11560 but I've also copied it down below:

+++ b/noir_stdlib/docs/nargo_doc.js
@@ -30,6 +30,11 @@ function showSidebar() {
 }
 
 function hideSidebar() {
+  // Only hide the sidebar if we are on a mobile device
+  if (document.documentElement.clientWidth >= 1200) {
+    return;
+  }
+
   main.style.display = 'block';
   sidebar.style.display = 'none';
   sidebarShown = false;
diff --git a/noir_stdlib/docs/styles.css b/noir_stdlib/docs/styles.css
index f526dd2318..8a7d737f21 100644
--- a/noir_stdlib/docs/styles.css
+++ b/noir_stdlib/docs/styles.css
@@ -25,6 +25,8 @@
     --string-color: light-dark(#718c00, #83a300);
     --doccomment-color: light-dark(#4d4d4c, #8ca375);
     --interpolation-color: light-dark(#119850, #bcca7d);
+    --table-border-color: #e0e0e0;
+    --table-alt-row-background-color: light-dark(#f5f5f5, #2a2a2a);
 
     --sidebar-toggle-height: 82px;
 }
@@ -137,6 +139,10 @@ ul.item-list, ul.sidebar-list {
     font-family: "Source Serif 4", NanumBarunGothic, serif;
 }
 
+.comments pre {
+    overflow: auto;
+}
+
 .comments code, .item-description code {
     background-color: var(--code-color);
     border-radius: 6px;
@@ -305,6 +311,20 @@ ul.item-list, ul.sidebar-list {
     overflow-x: hidden;
 }
 
+table {
+    margin: .5em 0;
+    border-collapse: collapse;
+}
+
+table th, table td {
+    padding: .5em;
+    border: 1px solid var(--table-border-color);
+}
+
+table tbody tr:nth-child(2n) {
+    background: var(--table-alt-row-background-color);
+}
+
 /* mobile */
 @media (max-width: 1199px) {
   body {

Yes @jfecher, i didnt have to use the diff starting with cargo b and reinstalling nargo helped.
Hopefully it passes now :)

CC @TomAFrench may need a force merge here as the upload brillig execution reports CI step is failing.

Thanks for all the changes @illegalcall! PR looks good now.

Glad to be a part of this, and thank you @jfecher for helping out.

Its unfortunate to see so many merge conflicts here 🙁. Should i go ahead and resolve them, if there is a posiblity of merging this soon? @jfecher

I'll pull this branch into the repo so we can clean up the merge conflicts and get it over the line

Thank you so much, lmk if anything comes up with which I can help. :)