Fix extra trailing '\0' char in uvwasi_path_readlink#263
Merged
mhdawson merged 1 commit intonodejs:mainfrom May 2, 2024
Merged
Fix extra trailing '\0' char in uvwasi_path_readlink#263mhdawson merged 1 commit intonodejs:mainfrom
mhdawson merged 1 commit intonodejs:mainfrom
Conversation
Member
|
@Brooooooklyn looks like some of the tests fail, can you take a look? |
Contributor
Author
|
@mhdawson, my last fix was wrong, so I've updated my patch. The test should pass now. Thanks for the review. |
Member
|
@Brooooooklyn thanks for updating, running CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the WASI spec: https://github.com/WebAssembly/WASI/blob/v0.2.0/legacy/preview1/witx/wasi_snapshot_preview1.witx#L389
The
path_readlinkshould behave the same as the posixreadlinkat, so that thebufusedshould not contain the null termination.read_linkis followed by an extra \0 #262