updates to serdes APIs #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the serdes bounds checking macros to be written in terms of sizes instead of data types. The reasons for the change are: 1. Many bounds checks are needed in terms of a string length, which wasn't handled by the previous implementation. 2. The previous version used partial data type names, which could look confusing in calling code. This new version will take more characters, but be more explicit/understandable.
This commit adds serdes support for the iov types.
This commit adds serdes functions for reading iovec_t and ciovec_t arrays.
This commit changes the bounds checking macros into functions. In practice, this silences warnings about comparisons of unsigned expressions >= always being true.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iovec_tandciovec_tsupport is added.Fixes: #69
Tested with these changes made in Node.js - https://ci.nodejs.org/job/node-test-commit/38386/