feat(recipes): add Linux usdt build #19
Conversation
recipes/x64-usdt/Dockerfile
Outdated
| python \ | ||
| ccache \ | ||
| xz-utils \ | ||
| devtoolset-7 \ |
There was a problem hiding this comment.
I tried devtoolset-6, but there was an unmet dependency on cloudlinux (devtoolset-6-dwz, which is not available on https://repo.cloudlinux.com/cloudlinux/7/sclo/devtoolset-6/x86_64/)
There was a problem hiding this comment.
we're moving to devtoolset-8 for Node 14+ so maybe you should just jump to that
There was a problem hiding this comment.
Even for older Node.js versions?
There was a problem hiding this comment.
It should be safe, devtoolsets are nice that way, they'll pin you to the libc of the OS version. We treat them as fixed because there may be variations that break for folks who are expecting stability in a major version.
Since you're starting off with something fresh, you get to set the rules! You could say "oh, you can't use this on that OS, too old" if you wanted. So now's your chance to set the bar high so it doesn't feel like it's way too low in 3 years time.
There was a problem hiding this comment.
Makes sense, will update the PR tomorrow.
|
so what's the summary tagline for this one? "adds dtrace probes"? I assume it's useful for getting tracing data down into v8 that you can't get with a standard binary? |
|
Add USDT probes* to allow tracing of V8 GC calls and some HTTP events with compatible tracers (systemtap and BPF tracing tools). * I think we're past the point where calling them dtrace probes makes sense on Linux |
| RUN groupadd --gid 1000 node \ | ||
| && adduser --gid 1000 --uid 1000 node | ||
|
|
||
| COPY cloudlinux.repo /etc/yum.repos.d/cloudlinux.repo |
There was a problem hiding this comment.
@sam-github where are you getting devtoolset-8 from for the new stuff in Build? I guess we should try and be consistent here if @mmarchini opts to bump to it here.
There was a problem hiding this comment.
devtoolset-8 is package, its yum installable:
|
I thought we merged this PR already 🙃 I'll try to test it again this weekend to see if we can move forward with it. |
No description provided.