Skip to content

docs: correct npm script name and JSON syntax in examples#5496

Merged
metcoder95 merged 1 commit into
nodejs:mainfrom
lenoxfernando:docs/fix-wasm-script-name
Jul 3, 2026
Merged

docs: correct npm script name and JSON syntax in examples#5496
metcoder95 merged 1 commit into
nodejs:mainfrom
lenoxfernando:docs/fix-wasm-script-name

Conversation

@lenoxfernando

Copy link
Copy Markdown
Contributor
  • CONTRIBUTING.md says npm run build-wasm; the script in package.json is build:wasm.
  • The mock-request best-practices example is missing a comma after the headers property, so it throws a SyntaxError as written.

Found while running docrot, a small checker that verifies docs examples and links against the code. Happy to adjust anything.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.43%. Comparing base (2dc7e18) to head (ff231bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5496   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files         110      110           
  Lines       37278    37278           
=======================================
+ Hits        34829    34830    +1     
+ Misses       2449     2448    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 merged commit 3d78e1a into nodejs:main Jul 3, 2026
38 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants