fix: use legacy global dispatcher in v7#5368
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7.x #5368 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 112 112
Lines 35843 35843
=======================================
+ Hits 33297 33298 +1
+ Misses 2546 2545 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ronag
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getGlobalDispatcher()always readSymbol.for('undici.globalDispatcher.1')Reproduction
A minimal reproduction is available at:
https://github.com/mcollina/undici-7-8-global-dispatcher-repro
It installs only
undici@7.27.1andundici@8.3.0. The failure happens when undici v8 installs the global dispatcher and undici v7 fetch reads the v2 dispatcher slot while still using the v1 handler shape.Tests
npx borp --timeout 180000 -p "test/node-test/global-dispatcher-version.js"npm run lint -- test/node-test/global-dispatcher-version.js lib/global.js