Skip to content

cache formdata boundary#5292

Merged
mcollina merged 2 commits into
nodejs:mainfrom
KhafraDev:issue-4065
May 11, 2026
Merged

cache formdata boundary#5292
mcollina merged 2 commits into
nodejs:mainfrom
KhafraDev:issue-4065

Conversation

@KhafraDev

Copy link
Copy Markdown
Member

I hate low quality ai PRs, I do not hate ai generally. Most of this PR was done by Claude! It's just that people think submitting 6 low quality PRs in an hour is acceptable. The code patch their ai proposed only "taped over" the issue, which still existed in their awful patch.

I got ragebaited into fixing this bug.

fixes #4065

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@trivikr

trivikr commented May 11, 2026

Copy link
Copy Markdown
Member

Let's use existing #4403 for discussions on actions on low quality AI generated PRs?

Another maintainer had raised the concern in Aug 2025.
My suggestion from last week was to adopt Node.js org policy.

@KhafraDev

Copy link
Copy Markdown
Member Author

I'm just ranting

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (e101dcb) to head (aac9e77).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5292      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files         110      110              
  Lines       36533    36547      +14     
==========================================
+ Hits        34071    34089      +18     
+ Misses       2462     2458       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit df5ded9 into nodejs:main May 11, 2026
35 checks passed
@github-actions github-actions Bot mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undici didn't update Content-Type header for multipart/form-data requests after following redirects which leads to mismatch in request body and header

4 participants