ci: build Node FFI fixtures for shared-builtin tests#5275
Merged
Conversation
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5275 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 110 110
Lines 36384 36384
=======================================
Hits 33939 33939
Misses 2445 2445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
CI failure in the Node.js 26
--shared-builtin-undici/undici-pathjob:Example https://github.com/nodejs/undici/actions/runs/25594045521/job/75136796661
Rationale
Node.js v26 now includes FFI tests that require a native fixture library. The shared-builtin workflow invokes
tools/test.pydirectly, bypassing Node's Make targets that would normally build those fixtures first.Changes
build-ffi-tests.Features
N/A
Bug Fixes
Build Node FFI fixtures for shared-builtin tests
Breaking Changes and Deprecations
N/A
Status