fix(test): make http2-pseudo-headers test order-independent#5234
Merged
Conversation
The rawHeaders array from Node.js http2 server can arrive in different order depending on platform and Node.js version. Sort the array before comparison to make the test deterministic across all environments. Fixes #5219
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5234 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 110 110
Lines 36353 36353
=======================================
Hits 33909 33909
Misses 2444 2444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trivikr
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rawHeadersarray from Node.js http2 server can arrive in differentorder depending on platform and Node.js version. Sort the array before
comparison so the test is deterministic across all environments.
Fixes #5219