Skip to content

Conversation

@tenkirin
Copy link
Contributor

@tenkirin tenkirin commented Nov 3, 2025

This relates to...

Docs, fix #4657

Changes

Simply removed the unnecessary res.

- await res.body.dump(); // force consumption of body
+ await body.dump(); // force consumption of body

@metcoder95 metcoder95 merged commit 6301265 into nodejs:main Nov 3, 2025
30 of 33 checks passed
@tenkirin tenkirin deleted the docs/correct-example-code branch November 3, 2025 07:46
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (9271564) to head (4212e6c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4658      +/-   ##
==========================================
+ Coverage   92.84%   92.86%   +0.01%     
==========================================
  Files         106      106              
  Lines       33272    33272              
==========================================
+ Hits        30892    30897       +5     
+ Misses       2380     2375       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] incorrect example code in docs

3 participants