feat: add getUpstream() method to BalancedPool #4586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getUpstream(upstream) method that returns the Pool instance for a given upstream URL. This allows users to retrieve specific Pool instances for debugging, monitoring, or direct operations. - Implement getUpstream() method in BalancedPool class - Add comprehensive test coverage with TDD approach - Include TypeScript definitions and type tests - All tests pass with no lint errors Signed-off-by: Matteo Collina <hello@matteocollina.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new getUpstream() method to the BalancedPool class that allows retrieval of specific Pool instances for given upstream URLs. This enables users to access individual Pool instances for debugging, monitoring, and direct operations.
- Add
getUpstream()method to BalancedPool class for retrieving specific Pool instances - Add comprehensive test coverage for valid/invalid upstreams and edge cases
- Add TypeScript definitions and type tests for the new method
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/dispatcher/balanced-pool.js | Implements the getUpstream() method that finds and returns Pool instances by upstream URL |
| test/node-test/balanced-pool.js | Adds comprehensive test suite covering valid upstreams, non-existent upstreams, and destroyed pools |
| test/types/balanced-pool.test-d.ts | Adds TypeScript type tests to verify proper typing of the new method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Coverage
Use Cases
This enhancement allows developers to:
The method follows existing BalancedPool patterns and maintains backward compatibility.