fix: minor changes in dispatcher-base.js and types for Dispatcher #4556
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes minor improvements to the dispatcher-base.js file and updates TypeScript type definitions to ensure better error handling and type compliance. The changes focus on making the close and destroy methods more consistent while improving error stack trace quality.
- Standardized null coalescing assignment operators for cleaner code consistency
- Improved error instantiation timing to provide meaningful stack traces
- Updated JSDoc type annotations for better type checking
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
metcoder95
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close and destroy is now more similar. also the ClientDestroyedError is instantiated in the close function and not in the queueMicrotask to ensure that you have some meaningful stack.
regarding typings:
actually functions need to be sorted by descending arity.
https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html#ordering
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status