fix(proxy-agent): add missing return after callback-call #4553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing return statement after an error callback in the ProxyAgent class to prevent code execution from continuing after an error condition.
- Adds a return statement after the error callback when proxy response status is not 200
- Prevents subsequent code execution after the error callback is invoked
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KhafraDev
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detected this by activating n/callback-return
but i dont want to add that rule, because then we maybe have some discussions...
So if you think we should add the rule, then please remark it.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status