lint: activate n/no-process-exit #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we used process.exit sometimes in the past to disable test files. We should use skip option and not process.exit
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR activates the ESLint rule n/no-process-exit to enforce better error handling practices by discouraging the use of process.exit() in favor of more appropriate alternatives like test skipping options or process.exitCode.
- Activates the
n/no-process-exitESLint rule in the configuration - Replaces
process.exit()calls withprocess.exitCodeassignments where appropriate - Updates test files to use Node.js test runner's
skipoption instead ofprocess.exit()
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.js | Adds the n/no-process-exit rule to enforce better exit handling |
| test/interceptors/dump-interceptor.js | Replaces process.exit with test skip option for Windows compatibility |
| test/autobahn/report.js | Changes process.exit to process.exitCode assignment |
| test/autobahn/client.js | Changes process.exit to process.exitCode assignment |
| test/web-platform-tests/wpt-runner.mjs | Adds eslint-disable comment for legitimate process.exit usage |
| test/web-platform-tests/runner/test-runner.mjs | Adds eslint-disable comments for legitimate process.exit usage |
| build/wasm.js | Replaces one process.exit with throw statement, adds eslint-disable for legitimate usage |
| benchmarks/wait.js | Changes process.exit to process.exitCode assignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we used process.exit sometimes in the past to disable test files. We should use skip option and not process.exit
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status