chore: activate n/prefer-node-protocol to enforce 'node:' prefix for requiring node built-ins
#4547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r requiring node built-ins Increases consistency
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR activates the ESLint rule n/prefer-node-protocol to enforce the use of the 'node:' prefix when requiring Node.js built-in modules, improving consistency of import/require calls throughout the codebase.
- Adds the
n/prefer-node-protocolESLint rule to enforce'node:'prefix usage - Updates all import statements in test files to use the
'node:'prefix for built-in modules - Changes CI workflow to use latest Node.js version instead of LTS for more consistent linting
Reviewed Changes
Copilot reviewed 21 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.js | Adds the n/prefer-node-protocol ESLint rule configuration |
| .github/workflows/ci.yml | Updates Node.js version from LTS to latest for CI linting consistency |
| test/utils/esm-wrapper.mjs | Updates http import to use node: prefix |
| test/types/*.test-d.ts | Updates various Node.js built-in imports to use node: prefix |
| test/jest/parser-timeout.test.js | Updates events require to use node: prefix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 21 out of 34 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
metcoder95
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases consistency of imports/require calls.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status