ci: set write permissions on job level #4537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses security vulnerabilities by moving GitHub workflow permissions from the workflow level to the job level, following security best practices to limit permission scope.
- Relocates permissions from workflow-level to job-level in three GitHub Actions workflows
- Removes workflow-level permissions in triggered-autobahn.yml (read-only workflow)
- Adds minor formatting improvement in autobahn.yml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update-submodules.yml | Moves write permissions from workflow to job level |
| .github/workflows/triggered-autobahn.yml | Removes workflow-level permissions (job uses defaults) |
| .github/workflows/backport.yml | Moves write permissions from workflow to job level |
| .github/workflows/autobahn.yml | Adds blank line for formatting consistency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://github.com/nodejs/undici/security/code-scanning/395
https://github.com/nodejs/undici/security/code-scanning/386
https://github.com/nodejs/undici/security/code-scanning/385
https://github.com/nodejs/undici/security/code-scanning/384
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status