ci: run benchmarks on pull_requests and by pushing on specific branches only #4536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es only Currently benchmarks run twice if we collaborators create branches directly on the nodejs/undici repository. This fixes it by only running on our protected branches. Basically copy paste from the other workflows
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the benchmark CI workflow to prevent duplicate runs when collaborators push to branches on the main repository. The workflow now only runs on protected branches (main, current, next, v*) for push events while still running on all pull requests.
- Changes trigger conditions from general
push/pull_requestto specific branch targeting - Maintains pull request benchmarking while reducing unnecessary runs on feature branches
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently benchmarks run twice if we collaborators create branches directly on the nodejs/undici repository. This fixes it by only running on our protected branches. Basically copy paste from the other workflows
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status