ci: make nodejs-shared wf reusable, install binaryen for wasm-opt, test on node-nightly #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cachekey for ccache
Member
|
@richardlau PTAL |
Member
We still get the warning with this PR? |
Contributor
Author
|
@richardlau |
Contributor
Author
|
I am looking forward to see if now if node 24.8.0 is now definetly fixed. |
Contributor
Author
|
I actually think we should make this a reusable workflow and then also check with nightly builds.. |
Contributor
Author
|
beautiful :D |
richardlau
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we get a warning that wasm-opt is missing so also install binaryen
also it seems wrong to just cache the major version number. Storing the whole version tag seems better.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status