ci: add no-wasm-simd option #4533
Merged
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3aef31a to
badfb77
Compare
Member
|
This conflicts now |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CI configuration option to disable WASM SIMD functionality during testing. It introduces a no-wasm-simd input parameter to the Node.js workflow and creates a new test job that runs with WASM SIMD disabled.
- Adds
no-wasm-simdinput parameter to the Node.js workflow - Creates a new CI job specifically for testing with WASM SIMD disabled
- Sets the
UNDICI_NO_WASM_SIMDenvironment variable across all test steps
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/nodejs.yml | Adds no-wasm-simd input parameter and sets UNDICI_NO_WASM_SIMD environment variable in all test steps |
| .github/workflows/ci.yml | Creates new test-with-no-wasm-simd job and includes it in the required checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status