fix: pass down context in onConnect#3858
Merged
mcollina merged 3 commits intonodejs:mainfrom Nov 22, 2024
Merged
Conversation
mcollina
requested changes
Nov 21, 2024
Member
mcollina
left a comment
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
ronag
approved these changes
Nov 22, 2024
Contributor
|
...args is imho not that nice. i think it does not cover in the types or so, that it can have two arguments. only abort. |
Contributor
Author
|
I noticed that |
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
The retry and cache handlers do not pass down the context of the
onConnectmethod. This means that using the redirect handler with one of them will not pass the context to the main handler:Rationale
Changes
...argsto pass all the args (like in the decorator handler)onConnectis now called on the first connection instead that in the constructor, allowing to pass the contextFeatures
Bug Fixes
Breaking Changes and Deprecations
Status