fix: response error interceptor broken#3805
Merged
mcollina merged 4 commits intonodejs:mainfrom Nov 27, 2024
Merged
Conversation
metcoder95
approved these changes
Nov 7, 2024
Uzlopak
reviewed
Nov 7, 2024
Comment on lines
+88
to
+92
| return (dispatch) => { | ||
| return function Intercept (opts, handler) { | ||
| return dispatch(opts, new ResponseErrorHandler(opts, { handler })) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Hmm, this makes me having stomach ache
Contributor
Author
There was a problem hiding this comment.
Care to elaborate or give a suggestion?
Contributor
|
When we are already touching this file massively, should we extract the handler into a new file and put it into the handler folder? |
Member
|
It depends on what we do with that handler. |
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
The response-error interceptor
Rationale
The interceptor is currently broken since Request no longer accepts
throwOnErroras an option.Changes
throwOnErroras it is considered an invalid argument.Features
Bug Fixes
Breaking Changes and Deprecations
Status