chore: remove unused pre-commit dependency#3599
Merged
Uzlopak merged 1 commit intonodejs:mainfrom Sep 13, 2024
eXhumer:remove-unused-precommit-dependency
Merged
chore: remove unused pre-commit dependency#3599Uzlopak merged 1 commit intonodejs:mainfrom eXhumer:remove-unused-precommit-dependency
pre-commit dependency#3599Uzlopak merged 1 commit intonodejs:mainfrom
eXhumer:remove-unused-precommit-dependency
Conversation
* husky is used instead Signed-off-by: eXhumer <exhumer@exhumer.cc>
metcoder95
approved these changes
Sep 13, 2024
Uzlopak
approved these changes
Sep 13, 2024
Contributor
Uzlopak
left a comment
There was a problem hiding this comment.
pre-commit should in theory run the tests. but it doesnt. dead weight.
Merged
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#3593 (comment)
Rationale
pre-commitusage (introduced with commit 25b8a54) has been replaced with husky in #605.Changes
pre-commitfromdevDependenciesinpackage.jsonFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status