Remove patched DOM types#3533
Merged
mcollina merged 2 commits intonodejs:mainfrom Sep 2, 2024
eXhumer:remove-patched-dom-types
Merged
Remove patched DOM types#3533mcollina merged 2 commits intonodejs:mainfrom eXhumer:remove-patched-dom-types
mcollina merged 2 commits intonodejs:mainfrom
eXhumer:remove-patched-dom-types
Conversation
Contributor
Author
|
While back-porting this to |
added 2 commits
September 1, 2024 17:19
* see #3524 Signed-off-by: eXhumer <exhumer@exhumer.cc>
* Add minimum types for node based on engines.node version in package.json * Currently undici locks engine to node@>=18.17 * Get @types/node for 18.17.x specificially and lock to patch upgrades only for 18.17 Signed-off-by: eXhumer <exhumer@exhumer.cc>
Contributor
Author
|
Removed |
Member
|
I'm reopening #3531 because it seems it cannot backported 1-1. |
5 tasks
Merged
Closed
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #3524
PR #3531
Rationale
Several missing DOM types from
@types/nodewere added as part ofpatch.d.ts.Event&EventTargetexported DOM types in global were overwritten withpatch.d.ts.Changes
Event&EventTargettype and references to it from other declaration files.@types/nodeto~18.17.19.Features
N/A
Bug Fixes
Eventtype.Breaking Changes and Deprecations
N/A
Status
Notes
@types/nodeversion was updated to reflect the minimum supported engine version inpackage.json.