fix: retry handler provide invalid body with fetch#3365
Closed
climba03003 wants to merge 2 commits intonodejs:mainfrom
Closed
fix: retry handler provide invalid body with fetch#3365climba03003 wants to merge 2 commits intonodejs:mainfrom
climba03003 wants to merge 2 commits intonodejs:mainfrom
Conversation
Contributor
Author
|
Test failure seems unrelated to the PR, it failed to download |
ronag
requested changes
Jun 24, 2024
Member
ronag
left a comment
There was a problem hiding this comment.
We should not be buffering in memory.
metcoder95
reviewed
Jun 25, 2024
Member
metcoder95
left a comment
There was a problem hiding this comment.
Let's better throw, is safer and imposes less overhead, wdyt?
Member
|
Yes |
7 tasks
Contributor
Author
|
See #3389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #3356
Rationale
RetryHandlershould buffer the body instead of streaming to the next handler.The reason behind is that the body maybe used by the next handler immediately and leads to stacking multiple invalid response.
Changes
Buffer the body until the response is success or error.
It should result on all status code that is not
206to retain the current behavior.Features
Bug Fixes
Breaking Changes and Deprecations
I though it may increase in memory usage for non-fetch people, because the payload can be streamed before but not now.
But in order to retain the correct behavior for retry, buffering should happen.
Status