perf: convert object to params#3302
Merged
mcollina merged 3 commits intonodejs:mainfrom Jun 6, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert passing object to passing params to
writeBufferwriteIterablewriteBlobwriteStreamThis relates to...
Rationale
Generally speaking constructing new object and passing it to function is more costly than just passing params.
Also using deoptexplorer-vscode I have found that writeBuffer was deoptimized probably because off passing different shape of object.
Changes
writeBufferwriteIterablewriteBlobwriteStreamFeatures
Bug Fixes
Breaking Changes and Deprecations
Status