Skip to content

websocket: pre-calculated length #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsctx merged 1 commit into from
May 21, 2024
Merged

websocket: pre-calculated length #3284

tsctx merged 1 commit into from
May 21, 2024

Conversation

@tsctx
Copy link
Member

@tsctx tsctx commented May 21, 2024

No description provided.

tsctx
tsctx commented May 21, 2024
View reviewed changes
lib/web/websocket/util.js
throw new TypeError('Invalid utf-8 received.')
}

function bufferConcat (buffers, length) {
Copy link
Member Author

@tsctx tsctx May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid instance assertion in Buffer.concat.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2024

Autobahn Test Report

Summary

Type Count
OK 510
Failed 0
Non-Strict 4
Wrong Code 0
Unclean 0
Failed By Client 0
Informational 3
Unimplemented 0
Total Tests 517
Details
Test Case Behavior Close Behavior Duration Remote Close Code
1.1.1 OK OK 2 1000
1.1.2 OK OK 2 1000
1.1.3 OK OK 2 1000
1.1.4 OK OK 2 1000
1.1.5 OK OK 2 1000
1.1.6 OK OK 12 1000
1.1.7 OK OK 10 1000
1.1.8 OK OK 25 1000
1.2.1 OK OK 3 1000
1.2.2 OK OK 2 1000
1.2.3 OK OK 2 1000
1.2.4 OK OK 2 1000
1.2.5 OK OK 2 1000
1.2.6 OK OK 7 1000
1.2.7 OK OK 6 1000
1.2.8 OK OK 19 1000
2.1 OK OK 2 1000
2.2 OK OK 1 1000
2.3 OK OK 1 1000
2.4 OK OK 2 1000
2.5 OK OK 2 null
2.6 OK OK 25 1000
2.7 OK OK 1 1000
2.8 OK OK 1 1000
2.9 OK OK 1 1000
2.10 OK OK 4 1000
2.11 OK OK 19 1000
3.1 OK OK 1 null
3.2 OK OK 2 null
3.3 OK OK 1 null
3.4 OK OK 4 null
3.5 OK OK 1 null
3.6 OK OK 1 null
3.7 OK OK 1 null
4.1.1 OK OK 1 null
4.1.2 OK OK 1 null
4.1.3 OK OK 1 null
4.1.4 OK OK 1 null
4.1.5 OK OK 5 null
4.2.1 OK OK 1 null
4.2.2 OK OK 1 null
4.2.3 OK OK 1 null
4.2.4 OK OK 1 null
4.2.5 OK OK 4 null
5.1 OK OK 1 null
5.2 OK OK 1 null
5.3 OK OK 2 1000
5.4 OK OK 2 1000
5.5 OK OK 5 1000
5.6 OK OK 3 1000
5.7 OK OK 5 1000
5.8 OK OK 6 1000
5.9 OK OK 1 null
5.10 OK OK 1 null
5.11 OK OK 1 null
5.12 OK OK 1 null
5.13 OK OK 1 null
5.14 OK OK 1 null
5.15 OK OK 2 null
5.16 OK OK 1 null
5.17 OK OK 1 null
5.18 OK OK 1 null
5.19 OK OK 1003 1000
5.20 OK OK 1003 1000
6.1.1 OK OK 2 1000
6.1.2 OK OK 1 1000
6.1.3 OK OK 1 1000
6.2.1 OK OK 1 1000
6.2.2 OK OK 2 1000
6.2.3 OK OK 10 1000
6.2.4 OK OK 2 1000
6.3.1 OK OK 1 null
6.3.2 OK OK 1 null
6.4.1 NON-STRICT OK 2002 null
6.4.2 NON-STRICT OK 2003 null
6.4.3 NON-STRICT OK 2003 null
6.4.4 NON-STRICT OK 2002 null
6.5.1 OK OK 2 1000
6.5.2 OK OK 1 1000
6.5.3 OK OK 2 1000
6.5.4 OK OK 1 1000
6.5.5 OK OK 1 1000
6.6.1 OK OK 1 null
6.6.2 OK OK 2 1000
6.6.3 OK OK 1 null
6.6.4 OK OK 1 null
6.6.5 OK OK 1 1000
6.6.6 OK OK 1 null
6.6.7 OK OK 4 1000
6.6.8 OK OK 1 null
6.6.9 OK OK 1 1000
6.6.10 OK OK 1 null
6.6.11 OK OK 1 1000
6.7.1 OK OK 1 1000
6.7.2 OK OK 1 1000
6.7.3 OK OK 1 1000
6.7.4 OK OK 1 1000
6.8.1 OK OK 1 null
6.8.2 OK OK 1 null
6.9.1 OK OK 1 1000
6.9.2 OK OK 2 1000
6.9.3 OK OK 1 1000
6.9.4 OK OK 1 1000
6.10.1 OK OK 1 null
6.10.2 OK OK 1 null
6.10.3 OK OK 1 null
6.11.1 OK OK 1 1000
6.11.2 OK OK 1 1000
6.11.3 OK OK 1 1000
6.11.4 OK OK 1 1000
6.11.5 OK OK 1 null
6.12.1 OK OK 1 null
6.12.2 OK OK 1 null
6.12.3 OK OK 1 null
6.12.4 OK OK 1 null
6.12.5 OK OK 1 null
6.12.6 OK OK 1 null
6.12.7 OK OK 1 null
6.12.8 OK OK 1 null
6.13.1 OK OK 1 null
6.13.2 OK OK 1 null
6.13.3 OK OK 1 null
6.13.4 OK OK 1 null
6.13.5 OK OK 1 null
6.14.1 OK OK 1 null
6.14.2 OK OK 1 null
6.14.3 OK OK 1 null
6.14.4 OK OK 1 null
6.14.5 OK OK 1 null
6.14.6 OK OK 1 null
6.14.7 OK OK 1 null
6.14.8 OK OK 1 null
6.14.9 OK OK 1 null
6.14.10 OK OK 1 null
6.15.1 OK OK 1 null
6.16.1 OK OK 1 null
6.16.2 OK OK 3 null
6.16.3 OK OK 1 null
6.17.1 OK OK 1 null
6.17.2 OK OK 1 null
6.17.3 OK OK 1 null
6.17.4 OK OK 1 null
6.17.5 OK OK 10 null
6.18.1 OK OK 1 null
6.18.2 OK OK 1 null
6.18.3 OK OK 1 null
6.18.4 OK OK 1 null
6.18.5 OK OK 1 null
6.19.1 OK OK 1 null
6.19.2 OK OK 1 null
6.19.3 OK OK 4 null
6.19.4 OK OK 1 null
6.19.5 OK OK 1 null
6.20.1 OK OK 1 null
6.20.2 OK OK 1 null
6.20.3 OK OK 1 null
6.20.4 OK OK 4 null
6.20.5 OK OK 1 null
6.20.6 OK OK 1 null
6.20.7 OK OK 1 null
6.21.1 OK OK 1 null
6.21.2 OK OK 1 null
6.21.3 OK OK 1 null
6.21.4 OK OK 1 null
6.21.5 OK OK 1 null
6.21.6 OK OK 1 null
6.21.7 OK OK 1 null
6.21.8 OK OK 1 null
6.22.1 OK OK 4 1000
6.22.2 OK OK 2 1000
6.22.3 OK OK 1 1000
6.22.4 OK OK 2 1000
6.22.5 OK OK 1 1000
6.22.6 OK OK 1 1000
6.22.7 OK OK 1 1000
6.22.8 OK OK 1 1000
6.22.9 OK OK 2 1000
6.22.10 OK OK 1 1000
6.22.11 OK OK 1 1000
6.22.12 OK OK 2 1000
6.22.13 OK OK 3 1000
6.22.14 OK OK 8 1000
6.22.15 OK OK 2 1000
6.22.16 OK OK 1 1000
6.22.17 OK OK 2 1000
6.22.18 OK OK 1 1000
6.22.19 OK OK 2 1000
6.22.20 OK OK 1 1000
6.22.21 OK OK 1 1000
6.22.22 OK OK 1 1000
6.22.23 OK OK 2 1000
6.22.24 OK OK 1 1000
6.22.25 OK OK 1 1000
6.22.26 OK OK 5 1000
6.22.27 OK OK 2 1000
6.22.28 OK OK 1 1000
6.22.29 OK OK 2 1000
6.22.30 OK OK 1 1000
6.22.31 OK OK 1 1000
6.22.32 OK OK 1 1000
6.22.33 OK OK 1 1000
6.22.34 OK OK 2 1000
6.23.1 OK OK 1 1000
6.23.2 OK OK 1 1000
6.23.3 OK OK 1 1000
6.23.4 OK OK 1 1000
6.23.5 OK OK 1 1000
6.23.6 OK OK 1 1000
6.23.7 OK OK 1 1000
7.1.1 OK OK 1 1000
7.1.2 OK OK 1 1000
7.1.3 OK OK 1 1000
7.1.4 OK OK 1 1000
7.1.5 OK OK 1 1000
7.1.6 INFORMATIONAL INFORMATIONAL 10 1000
7.3.1 OK OK 1 null
7.3.2 OK OK 1 null
7.3.3 OK OK 1 1000
7.3.4 OK OK 1 1000
7.3.5 OK OK 1 1000
7.3.6 OK OK 1 null
7.5.1 OK OK 2 1007
7.7.1 OK OK 1 1000
7.7.2 OK OK 1 1001
7.7.3 OK OK 1 1002
7.7.4 OK OK 1 1003
7.7.5 OK OK 1 1007
7.7.6 OK OK 1 1008
7.7.7 OK OK 1 1009
7.7.8 OK OK 1 1010
7.7.9 OK OK 1 1011
7.7.10 OK OK 1 3000
7.7.11 OK OK 1 3999
7.7.12 OK OK 1 4000
7.7.13 OK OK 1 4999
7.9.1 OK OK 1 1002
7.9.2 OK OK 1 1002
7.9.3 OK OK 1 1002
7.9.4 OK OK 1 1002
7.9.5 OK OK 1 1002
7.9.6 OK OK 1 1002
7.9.7 OK OK 1 1002
7.9.8 OK OK 1 1002
7.9.9 OK OK 1 1002
7.13.1 INFORMATIONAL INFORMATIONAL 1 1002
7.13.2 INFORMATIONAL INFORMATIONAL 1 1002
9.1.1 OK OK 2 1000
9.1.2 OK OK 5 1000
9.1.3 OK OK 83 1000
9.1.4 OK OK 74 1000
9.1.5 OK OK 130 1000
9.1.6 OK OK 245 1000
9.2.1 OK OK 3 1000
9.2.2 OK OK 5 1000
9.2.3 OK OK 11 1000
9.2.4 OK OK 65 1000
9.2.5 OK OK 105 1000
9.2.6 OK OK 222 1000
9.3.1 OK OK 171 1000
9.3.2 OK OK 74 1000
9.3.3 OK OK 80 1000
9.3.4 OK OK 46 1000
9.3.5 OK OK 39 1000
9.3.6 OK OK 66 1000
9.3.7 OK OK 40 1000
9.3.8 OK OK 39 1000
9.3.9 OK OK 41 1000
9.4.1 OK OK 114 1000
9.4.2 OK OK 48 1000
9.4.3 OK OK 31 1000
9.4.4 OK OK 46 1000
9.4.5 OK OK 36 1000
9.4.6 OK OK 27 1000
9.4.7 OK OK 28 1000
9.4.8 OK OK 29 1000
9.4.9 OK OK 51 1000
9.5.1 OK OK 383 1000
9.5.2 OK OK 138 1000
9.5.3 OK OK 77 1000
9.5.4 OK OK 47 1000
9.5.5 OK OK 31 1000
9.5.6 OK OK 43 1000
9.6.1 OK OK 282 1000
9.6.2 OK OK 134 1000
9.6.3 OK OK 76 1000
9.6.4 OK OK 45 1000
9.6.5 OK OK 29 1000
9.6.6 OK OK 24 1000
9.7.1 OK OK 282 1000
9.7.2 OK OK 196 1000
9.7.3 OK OK 106 1000
9.7.4 OK OK 181 1000
9.7.5 OK OK 127 1000
9.7.6 OK OK 189 1000
9.8.1 OK OK 167 1000
9.8.2 OK OK 176 1000
9.8.3 OK OK 146 1000
9.8.4 OK OK 161 1000
9.8.5 OK OK 141 1000
9.8.6 OK OK 233 1000
10.1.1 OK OK 4 1000
12.1.1 OK OK 406 1000
12.1.2 OK OK 427 1000
12.1.3 OK OK 326 1000
12.1.4 OK OK 311 1000
12.1.5 OK OK 432 1000
12.1.6 OK OK 508 1000
12.1.7 OK OK 682 1000
12.1.8 OK OK 1150 1000
12.1.9 OK OK 1905 1000
12.1.10 OK OK 3517 1000
12.1.11 OK OK 659 1000
12.1.12 OK OK 858 1000
12.1.13 OK OK 1369 1000
12.1.14 OK OK 2477 1000
12.1.15 OK OK 4531 1000
12.1.16 OK OK 3738 1000
12.1.17 OK OK 3524 1000
12.1.18 OK OK 3470 1000
12.2.1 OK OK 298 1000
12.2.2 OK OK 238 1000
12.2.3 OK OK 321 1000
12.2.4 OK OK 352 1000
12.2.5 OK OK 557 1000
12.2.6 OK OK 773 1000
12.2.7 OK OK 1242 1000
12.2.8 OK OK 2247 1000
12.2.9 OK OK 4210 1000
12.2.10 OK OK 8001 1000
12.2.11 OK OK 2209 1000
12.2.12 OK OK 4023 1000
12.2.13 OK OK 7816 1000
12.2.14 OK OK 15376 1000
12.2.15 OK OK 31367 1000
12.2.16 OK OK 13897 1000
12.2.17 OK OK 9669 1000
12.2.18 OK OK 8404 1000
12.3.1 OK OK 240 1000
12.3.2 OK OK 256 1000
12.3.3 OK OK 284 1000
12.3.4 OK OK 363 1000
12.3.5 OK OK 638 1000
12.3.6 OK OK 965 1000
12.3.7 OK OK 1684 1000
12.3.8 OK OK 3041 1000
12.3.9 OK OK 5811 1000
12.3.10 OK OK 11247 1000
12.3.11 OK OK 1674 1000
12.3.12 OK OK 3000 1000
12.3.13 OK OK 5616 1000
12.3.14 OK OK 10744 1000
12.3.15 OK OK 21989 1000
12.3.16 OK OK 13978 1000
12.3.17 OK OK 12070 1000
12.3.18 OK OK 11333 1000
12.4.1 OK OK 456 1000
12.4.2 OK OK 469 1000
12.4.3 OK OK 465 1000
12.4.4 OK OK 498 1000
12.4.5 OK OK 639 1000
12.4.6 OK OK 793 1000
12.4.7 OK OK 970 1000
12.4.8 OK OK 1388 1000
12.4.9 OK OK 2374 1000
12.4.10 OK OK 4296 1000
12.4.11 OK OK 763 1000
12.4.12 OK OK 1122 1000
12.4.13 OK OK 1759 1000
12.4.14 OK OK 2966 1000
12.4.15 OK OK 5735 1000
12.4.16 OK OK 4683 1000
12.4.17 OK OK 4384 1000
12.4.18 OK OK 4302 1000
12.5.1 OK OK 250 1000
12.5.2 OK OK 293 1000
12.5.3 OK OK 300 1000
12.5.4 OK OK 346 1000
12.5.5 OK OK 509 1000
12.5.6 OK OK 695 1000
12.5.7 OK OK 1093 1000
12.5.8 OK OK 1807 1000
12.5.9 OK OK 3366 1000
12.5.10 OK OK 6355 1000
12.5.11 OK OK 2044 1000
12.5.12 OK OK 3546 1000
12.5.13 OK OK 6798 1000
12.5.14 OK OK 13665 1000
12.5.15 OK OK 27785 1000
12.5.16 OK OK 11485 1000
12.5.17 OK OK 7677 1000
12.5.18 OK OK 6469 1000
13.1.1 OK OK 313 1000
13.1.2 OK OK 296 1000
13.1.3 OK OK 307 1000
13.1.4 OK OK 328 1000
13.1.5 OK OK 431 1000
13.1.6 OK OK 512 1000
13.1.7 OK OK 709 1000
13.1.8 OK OK 1133 1000
13.1.9 OK OK 1979 1000
13.1.10 OK OK 3582 1000
13.1.11 OK OK 627 1000
13.1.12 OK OK 832 1000
13.1.13 OK OK 1430 1000
13.1.14 OK OK 2531 1000
13.1.15 OK OK 4921 1000
13.1.16 OK OK 4040 1000
13.1.17 OK OK 3663 1000
13.1.18 OK OK 3649 1000
13.2.1 OK OK 298 1000
13.2.2 OK OK 299 1000
13.2.3 OK OK 315 1000
13.2.4 OK OK 352 1000
13.2.5 OK OK 446 1000
13.2.6 OK OK 584 1000
13.2.7 OK OK 719 1000
13.2.8 OK OK 1184 1000
13.2.9 OK OK 1983 1000
13.2.10 OK OK 3621 1000
13.2.11 OK OK 588 1000
13.2.12 OK OK 845 1000
13.2.13 OK OK 1486 1000
13.2.14 OK OK 2622 1000
13.2.15 OK OK 4864 1000
13.2.16 OK OK 3981 1000
13.2.17 OK OK 3665 1000
13.2.18 OK OK 3638 1000
13.3.1 OK OK 331 1000
13.3.2 OK OK 319 1000
13.3.3 OK OK 323 1000
13.3.4 OK OK 342 1000
13.3.5 OK OK 435 1000
13.3.6 OK OK 518 1000
13.3.7 OK OK 707 1000
13.3.8 OK OK 1167 1000
13.3.9 OK OK 2006 1000
13.3.10 OK OK 3709 1000
13.3.11 OK OK 594 1000
13.3.12 OK OK 875 1000
13.3.13 OK OK 1453 1000
13.3.14 OK OK 2623 1000
13.3.15 OK OK 4809 1000
13.3.16 OK OK 3927 1000
13.3.17 OK OK 3654 1000
13.3.18 OK OK 3606 1000
13.4.1 OK OK 363 1000
13.4.2 OK OK 307 1000
13.4.3 OK OK 338 1000
13.4.4 OK OK 345 1000
13.4.5 OK OK 443 1000
13.4.6 OK OK 532 1000
13.4.7 OK OK 742 1000
13.4.8 OK OK 1262 1000
13.4.9 OK OK 2021 1000
13.4.10 OK OK 3629 1000
13.4.11 OK OK 616 1000
13.4.12 OK OK 892 1000
13.4.13 OK OK 1479 1000
13.4.14 OK OK 2525 1000
13.4.15 OK OK 4706 1000
13.4.16 OK OK 3910 1000
13.4.17 OK OK 3703 1000
13.4.18 OK OK 3662 1000
13.5.1 OK OK 320 1000
13.5.2 OK OK 321 1000
13.5.3 OK OK 339 1000
13.5.4 OK OK 359 1000
13.5.5 OK OK 453 1000
13.5.6 OK OK 617 1000
13.5.7 OK OK 732 1000
13.5.8 OK OK 1162 1000
13.5.9 OK OK 1970 1000
13.5.10 OK OK 3698 1000
13.5.11 OK OK 622 1000
13.5.12 OK OK 889 1000
13.5.13 OK OK 1459 1000
13.5.14 OK OK 2558 1000
13.5.15 OK OK 4825 1000
13.5.16 OK OK 3860 1000
13.5.17 OK OK 3593 1000
13.5.18 OK OK 3642 1000
13.6.1 OK OK 313 1000
13.6.2 OK OK 306 1000
13.6.3 OK OK 328 1000
13.6.4 OK OK 395 1000
13.6.5 OK OK 445 1000
13.6.6 OK OK 543 1000
13.6.7 OK OK 791 1000
13.6.8 OK OK 1111 1000
13.6.9 OK OK 1985 1000
13.6.10 OK OK 3669 1000
13.6.11 OK OK 645 1000
13.6.12 OK OK 882 1000
13.6.13 OK OK 1504 1000
13.6.14 OK OK 2570 1000
13.6.15 OK OK 4877 1000
13.6.16 OK OK 3878 1000
13.6.17 OK OK 3636 1000
13.6.18 OK OK 3734 1000
13.7.1 OK OK 329 1000
13.7.2 OK OK 333 1000
13.7.3 OK OK 330 1000
13.7.4 OK OK 368 1000
13.7.5 OK OK 455 1000
13.7.6 OK OK 528 1000
13.7.7 OK OK 813 1000
13.7.8 OK OK 1133 1000
13.7.9 OK OK 2001 1000
13.7.10 OK OK 3606 1000
13.7.11 OK OK 609 1000
13.7.12 OK OK 928 1000
13.7.13 OK OK 1428 1000
13.7.14 OK OK 2610 1000
13.7.15 OK OK 4784 1000
13.7.16 OK OK 3851 1000
13.7.17 OK OK 3669 1000
13.7.18 OK OK 3648 1000

@tsctx tsctx merged commit 13523fd into nodejs:main May 21, 2024
@tsctx tsctx deleted the websocket/fragments-byte-length branch May 21, 2024 14:08
@github-actions github-actions bot mentioned this pull request May 22, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Jun 14, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Jun 24, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jun 29, 2024
Merged
This was referenced Jul 8, 2024
Open
Open
@bburns bburns mentioned this pull request Jul 12, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 12, 2024
Merged
This was referenced Jul 24, 2024
Merged
Merged
Merged
@lholmquist lholmquist mentioned this pull request Aug 2, 2024
Closed
@lholmquist lholmquist mentioned this pull request Aug 7, 2024
Merged
@leonardoadame leonardoadame mentioned this pull request Aug 12, 2024
Open
@davehorton davehorton mentioned this pull request Aug 21, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 21, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Aug 31, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsctx @KhafraDev