ci: node nightly test should use node 23#3248
Merged
Uzlopak merged 1 commit intonodejs:mainfrom May 12, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
today again i got an email that our nightly fails. checked it and wondered why node nightly from 24 april was used. checked the node page and saw, that since we have node 23, no node 22 nightlies are published. So we have to change the target.
Also here I wonder if the following condition is correct:
undici/.github/workflows/nightly.yml
Line 37 in 38c8b55
I would actually say, that it should be or conditions and not and conditions. If the tests fail in windows but mac and linux pass, as it is now, then we dont get an issue created. Rn i still get an email that it failed.
Maybe @mweberxyz share his opinion?
Maybe can be taken care in a follow up.