fix(H2 Client): bind stream 'data' listener only after received 'response' event#2985
Merged
ronag merged 6 commits intonodejs:mainfrom Mar 25, 2024
Merged
fix(H2 Client): bind stream 'data' listener only after received 'response' event#2985ronag merged 6 commits intonodejs:mainfrom
ronag merged 6 commits intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#2808
Rationale
Sporadically when doing massive h2 requests for a certain period of time a breaking assertion is triggered "assert(!this.aborted)" in onHeaders Method [undici/lib/core/request.js] causing application crash
Changes
Features
N/A
Bug Fixes
Breaking Changes and Deprecations
Status
[cert]: https://github.com/nodejs/undici/blob/main/CONTRIBUTING.md #