fix(types): responseHeaders typo in type#2317
Closed
vickvu wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
- Coverage 85.54% 85.43% -0.12%
==========================================
Files 76 76
Lines 6858 6866 +8
==========================================
- Hits 5867 5866 -1
- Misses 991 1000 +9
☔ View full report in Codecov by Sentry. |
Ethan-Arrowood
approved these changes
Oct 11, 2023
mcollina
requested changes
Oct 16, 2023
Member
mcollina
left a comment
There was a problem hiding this comment.
Can you add a test for this? We use tsd to verify our types.
Contributor
|
@vickvu Do you need help with this? |
7 tasks
Member
|
Fixed by #3375 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
The name of the field should be
responseHeadersChanges
Change the field name to
responseHeadersFeatures
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status