Skip to content

Can we remove npm run test from pre-commit hook?  #2274

@Ethan-Arrowood

Description

@Ethan-Arrowood

As titled.

I'm finding it extremely annoying that all of the tests run every time I commit. We should enforce commit squashing anyways when we merge PRs so that not every commit has to be valid.

I currently pass -n every time I commit simply because I don't want to wait for the tests to run, but then when I use npm version and it commits a tag, that hook still runs and there's no way for me to disable it.

Maintainers, WDYT?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions