Lazily require abort-controller#478
Merged
Merged
Conversation
…dled, then loaded in node
Contributor
Author
|
It looks like your |
Member
|
Could you do the changes in the build script and re-run them? Take a look at https://github.com/nodejs/readable-stream/blob/main/build/replacements.mjs. |
…mize the changeset.
Contributor
Author
|
Things I didn't fix (yet) because they aren't germane to the issue at hand:
|
Member
|
Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It throws when it has been bundled, then loaded in node.
How I found this:
cbor-websub-package, I use webpack to pre-bundlecborfor easy use in the browserTypeError: Cannot destructure property 'AbortController'abort-controller, which should only get used in the browser, but because I'm running a bundle, I hit it in nodeabort-controllerunlessglobalThis.AbortControllerdoesn't existglobalThis.AbortControllercheck fixes my issueThis is probably an edge case that I hope nobody else runs into, but the fix for my problem shouldn't hurt anyone else.