v4 launch details#472
Merged
Merged
Conversation
vweevers
reviewed
May 23, 2022
benjamingr
approved these changes
May 24, 2022
Member
|
(with the readme example fix) |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
vweevers
reviewed
Jun 4, 2022
vweevers
reviewed
Jun 4, 2022
vweevers
approved these changes
Jun 4, 2022
vweevers
left a comment
Contributor
There was a problem hiding this comment.
The closing of various GH issues after #471 created ambiguity about what is and isn't supported (mainly: does a bundler need to inject shims) and the list of changes is long. Makes me wish we had a complete and standardized changelog. But that's a lot of work and v4 already has been. So LGTM (with two nits) though I do worry about maintainability going forward.
Co-authored-by: Vincent Weevers <mail@vincentweevers.nl>
Co-authored-by: Vincent Weevers <mail@vincentweevers.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Collina hello@matteocollina.com