Skip to content

fix: properly hook builtin modules that require the 'node:' prefix #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BridgeAR merged 2 commits into from
Jan 27, 2026
Merged

fix: properly hook builtin modules that require the 'node:' prefix #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e106f
fix: properly hook builtin modules that require the 'node:' prefix
trentm Jan 26, 2026
d5eb789
provide fallback for isBuiltin to avoid typeof check everytime
trentm Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ const parse = require('module-details-from-path')
const { fileURLToPath } = require('url')
const { MessageChannel } = require('worker_threads')

let { isBuiltin } = require('module')
if (!isBuiltin) {
isBuiltin = () => true
}

const {
importHooks,
specifiers,
Expand Down Expand Up @@ -124,11 +129,17 @@ function Hook (modules, options, hookFn) {

this._iitmHook = (name, namespace, specifier) => {
const filename = name
const isBuiltin = name.startsWith('node:')
const isNodeUrl = name.startsWith('node:')
let baseDir

if (isBuiltin) {
name = name.replace(/^node:/, '')
if (isNodeUrl) {
// Normalize builtin module name to *not* have 'node:' prefix, unless
// required, as it is for 'node:test' and some others. `module.isBuiltin`
// is available in all Node.js versions that have node:-only modules.
const unprefixed = name.slice(5)
if (isBuiltin(unprefixed)) {
name = unprefixed
}
} else {
if (name.startsWith('file://')) {
const stackTraceLimit = Error.stackTraceLimit
Expand Down
12 changes: 12 additions & 0 deletions test/hook/v18.15-node-prefixed-only.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Test that a builtin module that must use 'node:' prefix works.
import { strictEqual } from 'assert'
import Hook from '../../index.js'

Hook(['node:test'], (exports, name) => {
if (name === 'node:test') {
exports.skip = 'iitm was here'
}
})

const { skip } = await import('node:test')
strictEqual(skip, 'iitm was here')