fix: Account for invalid identifiers#198
Merged
AbhiPrasad merged 4 commits intonodejs:mainfrom Jun 12, 2025
Merged
Conversation
AbhiPrasad
commented
Jun 11, 2025
hook.js
Outdated
| } else { | ||
| const variableName = `$${n.replace(/[^a-zA-Z0-9_]/g, '_')}` | ||
| const objectKey = JSON.stringify(n) | ||
| const reExportedName = n === 'default' ? n : objectKey |
Member
Author
There was a problem hiding this comment.
default has to be special-cased here, not sure if anything else applies.
Member
Author
|
Hmm there are more edge cases I'm missing - drafting this while I figure it out. |
Member
Author
|
added a version check - this is ready to review now! |
jsumners-nr
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 16 and above allows you to use interesting string identifiers like
"module.exports"and"unsigned short"as valid export names.ref https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export
This PR accounts for that by updating our shim variable name logic, and adjusting how we do getters and setters so that we don't break when encoutering these "invalid" identifiers.
supercedes #115
resolves #94
If you can, please give this a test locally. I tried it myself on some test apps and worked fine.