fix: Include source url for parsing failures#109
Merged
timfish merged 3 commits intonodejs:mainfrom Jun 29, 2024
Merged
Conversation
jsumners-nr
approved these changes
Jun 18, 2024
This comment has been minimized.
This comment has been minimized.
Contributor
|
Do not use |
This was referenced Jul 3, 2024
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #106 might not get merged, I cherry picked the improvements to logged error messages when module wrapping fails due to parsing failures.
processModulemay parse multiple files in the process of wrapping a module so it's important to log the exact file the fails parsing.