Skip to content

discuss R/IITM design for callback args with internals: true #244

@trentm

Description

@trentm

I did not get the chance to fully review this [PR #241] before it landed and I believe this change is actually not what we want, no matter that it deviates from ritm.

The reason is: if we declare internals: true, I really want to be on the safe side to always match the internal loaded file, no matter that the user loads it with the module name. That way it is safe that the correct code in fact always wrapped as expected. Otherwise, we would could up ending with a hook for the module name but not in case it is loaded directly by the user as internal file and I would have to declare a second hook that may only run in case the other one did not run and the other way around, if I am not mistaken (I did not yet verify this with a test case).

@trentm instead of aligning with ritm, I think we should consider changing ritm to also load the internal file when being loaded with the module name.

Originally posted by @BridgeAR in #241 (comment)


@BridgeAR, I moved this to a new issue so the conversation doesn't get lost. I'll try to reply shortly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions