Skip to content

GitHub Actions: Enable python-version: 3.5 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cclauss wants to merge 4 commits into from
Closed

GitHub Actions: Enable python-version: 3.5 #7

cclauss wants to merge 4 commits into from

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 2, 2019

No description provided.

ryzokuken
ryzokuken approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I'd try to squash and merge to avoid the merge commits creeping into master.

@ryzokuken
Copy link
Contributor

ryzokuken commented Dec 2, 2019

(P.S. 3.5 still fails?)

@targos
Copy link
Member

targos commented Mar 15, 2020

Error:

>     self.assertEqual(expected_msbuild_settings, actual_msbuild_settings)
E     AssertionError: {'ResourceCompile': {'AdditionalOptions': '[6986 chars] ''}} != {'': {'GenerateManifest': 'true', 'IgnoreIm[6983 chars] ''}}
E     Diff is 9880 characters long. Set self.maxDiff to None to see it.

pylib/gyp/MSVSSettings_test.py:1091: AssertionError
=========================== short test summary info ============================
FAILED pylib/gyp/MSVSSettings_test.py::TestSequenceFunctions::testConvertToMSBuildSettings_actual
FAILED pylib/gyp/MSVSSettings_test.py::TestSequenceFunctions::testConvertToMSBuildSettings_full_synthetic

@targos targos mentioned this pull request May 26, 2020
Open
@cclauss
Copy link
Contributor Author

cclauss commented Oct 17, 2020

Python 3.5 is end of life.

@cclauss cclauss closed this Oct 17, 2020
@cclauss cclauss deleted the Enable-python-version-3.5 branch October 17, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cclauss @ryzokuken @targos