Skip to content

jenkins: use gcc 8 on the benchmark machines #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardlau merged 1 commit into from
Jun 23, 2021
Merged

jenkins: use gcc 8 on the benchmark machines #2684

richardlau merged 1 commit into from
Jun 23, 2021

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Jun 22, 2021

Selects gcc/g++ 8 on the benchmark machines when building Node.js 16
or later.

Fixes: #2681

@richardlau
jenkins: use gcc 8 on the benchmark machines
e0e61d0 
Selects gcc/g++ 8 on the benchmark machines when building Node.js 16
or later.
@richardlau richardlau mentioned this pull request Jun 22, 2021
Closed
rvagg
rvagg approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're going to need to make sure we have ubuntu-toolchain-r onto 16.04 machines for this to work I think ... or get rid of them entirely

@richardlau
Copy link
Member Author

richardlau commented Jun 23, 2021

we're going to need to make sure we have ubuntu-toolchain-r onto 16.04 machines for this to work I think ... or get rid of them entirely

For reference, this happens in

build/ansible/roles/baselayout/tasks/partials/repo/ubuntu1604.yml

Lines 3 to 12 in 3aaa723

#
# add PPA for gcc updates
#
- name: "repo : add Ubuntu Toolchain PPA"
apt_repository:
repo: 'ppa:ubuntu-toolchain-r/test'
state: present
update_cache: yes
register: has_updated_package_repo

@richardlau richardlau merged commit 2c89789 into nodejs:master Jun 23, 2021
@richardlau richardlau deleted the ubuntu1604 branch June 23, 2021 09:44
@richardlau richardlau mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvagg rvagg rvagg approved these changes

@AshCripps AshCripps AshCripps approved these changes

Assignees

No one assigned

Labels

ansible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update GCC on benchmark-ubuntu1604-intel-64

3 participants

@richardlau @rvagg @AshCripps